linkUserByEmail: Split out helper functions, reduce scope of try/catches#521
Open
bheesham wants to merge 8 commits intomozilla-iam:masterfrom
Open
linkUserByEmail: Split out helper functions, reduce scope of try/catches#521bheesham wants to merge 8 commits intomozilla-iam:masterfrom
bheesham wants to merge 8 commits intomozilla-iam:masterfrom
Conversation
bheesham
force-pushed
the
split-up-link-users-by-email
branch
from
7349ee8 to
5c44301
Compare
bheesham
force-pushed
the
split-up-link-users-by-email
branch
from
5c44301 to
5bdc41b
Compare
Jira: IAM-1761
bheesham
force-pushed
the
split-up-link-users-by-email
branch
2 times, most recently
from
9521bb8 to
0eb74a3
Compare
Jira: IAM-1761
This should address cases not addressed by the Auth0 SDK. Since we don't currently collect logs as to why these calls may be failing, we simply log the error and move on (er, retry). Once we understand where this code is failing we should be more specific about our try/catches. Jira: IAM-1761
Jira: IAM-1761
Jira: IAM-1761
Jira: IAM-1761
bheesham
force-pushed
the
split-up-link-users-by-email
branch
from
0eb74a3 to
2e9b2a1
Compare
Jira: IAM-1761
Jira: IAM-1761
gcoxmoz
approved these changes
Feb 25, 2026
Contributor
gcoxmoz
left a comment
gcoxmoz
left a comment
There was a problem hiding this comment.
Not my primary language, but breakup of functions makes sense to me in each of the commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The general approach here was to:
onExecutePostLogin;try/catchblocks to be more specific;Jira: IAM-1761