feat: do not store home directory in desktop entry #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when `git-dev-open` is installed in `~/.local/bin`, the `.desktop` file can reference the binary name directly. This avoids embedding user-specific home directory paths in dotfiles or repos
moyiz
requested changes
Sep 4, 2025
Owner
moyiz
left a comment
moyiz
left a comment
There was a problem hiding this comment.
Thanks for submitting a PR.
I like the idea overall, but notice that it is not guaranteed that ~/.local/bin is actually in the user's PATH.
This feature can be generalized, i.e check whether the directory containing the script is in PATH, then update the desktop entry accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when
git-dev-openis installed in~/.local/bin, the.desktopfile can reference the binary name directly. This avoids embedding user-specific home directory paths in dotfiles or repos