Skip to content

fix ament_target_dependencies() deprecation #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mosfet80 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix ament_target_dependencies() deprecation #1072

mosfet80 wants to merge 4 commits into from

Conversation

@mosfet80
Copy link
Contributor

@mosfet80 mosfet80 commented Oct 14, 2025

Description

fix ament_target_dependencies deprecation

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@mosfet80 mosfet80 marked this pull request as draft October 14, 2025 15:25
@mosfet80 mosfet80 changed the title fix ament_target_deprecation fix ament_target_dependencies() deprecation Oct 14, 2025
@mosfet80 mosfet80 marked this pull request as ready for review December 11, 2025 13:16
stephanie-eng
stephanie-eng reviewed Dec 12, 2025
View reviewed changes
stephanie-eng
stephanie-eng reviewed Dec 12, 2025
View reviewed changes
@mosfet80 mosfet80 force-pushed the fixAment_targetdep branch 2 times, most recently from 5ca989d to 04325ef Compare December 14, 2025 21:08
@mosfet80 mosfet80 marked this pull request as draft December 14, 2025 22:29
@mosfet80 mosfet80 marked this pull request as ready for review December 14, 2025 22:30
@mosfet80 mosfet80 force-pushed the fixAment_targetdep branch from 5ab7dda to 0580ff1 Compare January 7, 2026 15:40
@mosfet80
fix ament_target_deprecation
4a97225 
fix  ament_target_dependencies deprecation

Update CMakeLists.txt
Update CMakeLists.txt
Update planning_scene_ros_api_tutorial.cpp

Update CMakeLists.txt
@mosfet80 mosfet80 force-pushed the fixAment_targetdep branch from 0580ff1 to 4a97225 Compare January 7, 2026 16:05
AndyZe
AndyZe approved these changes Jan 7, 2026
View reviewed changes
Copy link
Member

@AndyZe AndyZe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make these small changes then I'll merge it. :D

@AndyZe
Copy link
Member

AndyZe commented Jan 7, 2026

So I see the build fails because PickNik's reset_fault_controller package isn't available on Rolling. That's not related to this PR. What do you think, @mosfet80 ? Merge now regardless? Maybe find whatever tutorial depends on reset_fault_controller and skip building it, for now?

https://index.ros.org/?search_packages=true#rolling

@mosfet80 mosfet80 force-pushed the fixAment_targetdep branch from 8b6e47f to b73426f Compare January 7, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephanie-eng stephanie-eng stephanie-eng left review comments

@AndyZe AndyZe AndyZe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mosfet80 @AndyZe @stephanie-eng