Updated to use Bootstrap 4 classes#196
Updated to use Bootstrap 4 classes#196jasonsperske wants to merge 4 commits intomouse0270:masterfrom
Conversation
|
Here are methods that might be used to make a more universal plugin: https://stackoverflow.com/q/21369029/16959 |
It's really overwritten by the inline styles that the script adds
|
@mouse0270 , any time estimate on accepting this pull request? |
|
Any Update on this? |
|
Sorry guys, I took a year look alternative career choice. I am just getting back to programming. I am trying to look at all the pull request and issues. Thank you for being patient, you should see updates to issues and pull request over the next 2 weeks. |
|
Any update on the PR? I am looking at an alternative to PNotify that supports BS4. Thanks. |
|
Is this the BS4 version? |
| icon_type: 'class', | ||
| template: '<div data-notify="container" class="col-xs-11 col-sm-4 alert alert-{0}" role="alert"><button type="button" aria-hidden="true" class="close" data-notify="dismiss">×</button><span data-notify="icon"></span> <span data-notify="title">{1}</span> <span data-notify="message">{2}</span><div class="progress" data-notify="progressbar"><div class="progress-bar progress-bar-{0}" role="progressbar" aria-valuenow="0" aria-valuemin="0" aria-valuemax="100" style="width: 0%;"></div></div><a href="{3}" target="{4}" data-notify="url"></a></div>' | ||
| template: [ | ||
| '<div data-notify="container">', |
There was a problem hiding this comment.
the classes are missing for correct width
col-11 col-sm-4
Howdy, still no update? |
8 participants
I made a small tweak to the template to work with Bootstrap 4. I'm using my modified version in a project and it works great. I didn't know what version to assign it (since it breaks compatibility with Bootstrap 3 I figured it shouldn't be called 3.1.6), I guess 3.2.0 would be appropriate, but 4.0 seemed clearer. With a little work, I could add code to use the correct template HTML for the version of bootstrap the user has included (possibly by checking for specific CSS class names or maybe with something involving bootstrap.js).