fix: Add username to the tokenStoreKey so the saved token is invalidated when the user changes in the environment#426
Open
michaelarnauts wants to merge 1 commit intomountain-loop:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using environments to switch between users on the same OAuth2 server, the username isn't used when defining the
tokenStoreKey, so the token of a different user is used after switching the environment that causes the username to change.Without this fix, I have to use a workaround by modifying the Access Token URL so the
tokenStoreKeychanges. See screenshot below.Submission
CONTRIBUTING.md.Approved feedback item (required if not a bug fix or small-scope improvement):
Related
https://yaak.app/feedback/posts/changing-the-environment-doesn-t-invalidate-my-authentication-token