Migrate encryption to isolate pool, switch image/PDF cache from bytes to file#51
Merged
Conversation
Replace in-memory Uint8List cache with File references to avoid main-isolate decode stalls. Reading entire files into memory caused performance issues on large images; streaming from disk lets Flutter decode on the background rasterizer.
Remove the file-size threshold that previously decided between main- isolate and isolate-based encryption. Always use the encryptFileInIsolate path to prevent UI freezes during batch operations. Change deriveFileKey to its async variant deriveFileKeyAsync to avoid multi-second main-isolate stalls from PBKDF2 when opening encrypted files. For in-memory byte encryption, write to a temporary file so the isolate pool can process it, cleaning up afterward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates all encryption to the isolate pool (removing file-size threshold), makes key derivation async to prevent UI stalls, and switches decrypted image cache and PDF viewer from in-memory bytes to file references to avoid ANRs on large files.
Changes
Crypto Performance
encryptFileInIsolatederiveFileKeyto async variant to prevent main-isolate stallsImage/PDF Performance
File(avoids main-isolate decode stalls)UI
Build
Docs