[ES-2914] [DSD-9789] upgraded json form version.#1676
[ES-2914] [DSD-9789] upgraded json form version.#1676gk-XL7 wants to merge 1 commit intomosip:release-1.8.xfrom
Conversation
Signed-off-by: GurukiranP <talk2gurukiran@gmail.com>
WalkthroughUpdated the "@mosip/json-form-builder" dependency from a fixed version to a caret range constraint. Added CSS styling to increase the z-index stacking order for React tooltips with !important precedence. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@oidc-ui/package.json`:
- Line 7: Replace the caret-ranged beta dependency entries so they pin exact
versions: change "@mosip/json-form-builder": "^0.1.1-beta.6" to an exact version
string (e.g., "0.1.1-beta.6") and do the same for
"@mosip/secure-biometric-interface-integrator" to remove the leading caret;
update the package.json dependency values accordingly and run your lockfile
update (npm install / npm ci) to persist the pinned versions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 7938bb05-57f3-418e-bad7-8b963e76e299
⛔ Files ignored due to path filters (1)
oidc-ui/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
oidc-ui/package.jsonoidc-ui/src/App.css
| "dependencies": { | ||
| "@emotion/react": "^11.10.4", | ||
| "@mosip/json-form-builder": "0.1.1-beta.5", | ||
| "@mosip/json-form-builder": "^0.1.1-beta.6", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify the API usage in Form.js matches expected patterns from the library
echo "=== Checking JsonFormBuilder usage in the codebase ==="
rg -n "JsonFormBuilder" --type=js -C3
echo ""
echo "=== Checking for method calls on the form instance ==="
rg -nP '\.(render|updateLanguage|getFormData)\s*\(' --type=jsRepository: mosip/esignet
Length of output: 3104
🏁 Script executed:
#!/bin/bash
# Check for lock files that might already pin versions
echo "=== Looking for lock files ==="
find . -maxdepth 2 -type f \( -name "package-lock.json" -o -name "yarn.lock" \) -ls
echo ""
echo "=== Checking package.json structure and other dependencies ==="
head -30 oidc-ui/package.json
echo ""
echo "=== Checking for other caret-prefixed beta versions ==="
rg '"\^.*-beta' oidc-ui/package.jsonRepository: mosip/esignet
Length of output: 1408
Pin the exact beta version to prevent unintended updates.
While the lock file currently freezes the installed version, using caret (^) with beta versions creates ambiguity about intent. If the lock file is regenerated or npm update runs, the caret allows resolution to 0.1.1-beta.7, 0.1.1-beta.8, etc.—which don't follow standard semver backward-compatibility guarantees. This risks breaking the Form.js API calls (render(), updateLanguage(), getFormData()).
For clarity and stability, pin the exact version:
- "@mosip/json-form-builder": "^0.1.1-beta.6",
+ "@mosip/json-form-builder": "0.1.1-beta.6",Note: The same pattern applies to @mosip/secure-biometric-interface-integrator.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@mosip/json-form-builder": "^0.1.1-beta.6", | |
| "@mosip/json-form-builder": "0.1.1-beta.6", |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@oidc-ui/package.json` at line 7, Replace the caret-ranged beta dependency
entries so they pin exact versions: change "@mosip/json-form-builder":
"^0.1.1-beta.6" to an exact version string (e.g., "0.1.1-beta.6") and do the
same for "@mosip/secure-biometric-interface-integrator" to remove the leading
caret; update the package.json dependency values accordingly and run your
lockfile update (npm install / npm ci) to persist the pinned versions.
Summary by CodeRabbit
Chores
Style