Skip to content

[ES-2914] [DSD-9789] upgraded json form version.#1676

Open
gk-XL7 wants to merge 1 commit intomosip:release-1.8.xfrom
gk-XL7:ES-2914_release
Open

[ES-2914] [DSD-9789] upgraded json form version.#1676
gk-XL7 wants to merge 1 commit intomosip:release-1.8.xfrom
gk-XL7:ES-2914_release

Conversation

@gk-XL7
Copy link
Contributor

@gk-XL7 gk-XL7 commented Mar 18, 2026

Summary by CodeRabbit

  • Chores

    • Updated "@mosip/json-form-builder" dependency to the latest compatible version
  • Style

    • Enhanced tooltip display layering to prevent overlapping elements

Signed-off-by: GurukiranP <talk2gurukiran@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

Walkthrough

Updated the "@mosip/json-form-builder" dependency from a fixed version to a caret range constraint. Added CSS styling to increase the z-index stacking order for React tooltips with !important precedence.

Changes

Cohort / File(s) Summary
Dependency Management
oidc-ui/package.json
Updated "@mosip/json-form-builder" from exact version "0.1.1-beta.5" to caret range "^0.1.1-beta.6", allowing minor version updates.
Tooltip Styling
oidc-ui/src/App.css
Added .react-tooltip CSS rule with z-index: 9999 !important to ensure tooltips appear above other page elements.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A little hop, a version bump so neat,
Tooltips rise above, making UX complete! ✨
Z-index climbs to reach the sky,
Higher, higher—no longer shy! 🐰

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: upgrading the json-form-builder dependency version from 0.1.1-beta.5 to 0.1.1-beta.6.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@oidc-ui/package.json`:
- Line 7: Replace the caret-ranged beta dependency entries so they pin exact
versions: change "@mosip/json-form-builder": "^0.1.1-beta.6" to an exact version
string (e.g., "0.1.1-beta.6") and do the same for
"@mosip/secure-biometric-interface-integrator" to remove the leading caret;
update the package.json dependency values accordingly and run your lockfile
update (npm install / npm ci) to persist the pinned versions.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7938bb05-57f3-418e-bad7-8b963e76e299

📥 Commits

Reviewing files that changed from the base of the PR and between 2d73039 and 7decf26.

⛔ Files ignored due to path filters (1)
  • oidc-ui/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • oidc-ui/package.json
  • oidc-ui/src/App.css

"dependencies": {
"@emotion/react": "^11.10.4",
"@mosip/json-form-builder": "0.1.1-beta.5",
"@mosip/json-form-builder": "^0.1.1-beta.6",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify the API usage in Form.js matches expected patterns from the library
echo "=== Checking JsonFormBuilder usage in the codebase ==="
rg -n "JsonFormBuilder" --type=js -C3

echo ""
echo "=== Checking for method calls on the form instance ==="
rg -nP '\.(render|updateLanguage|getFormData)\s*\(' --type=js

Repository: mosip/esignet

Length of output: 3104


🏁 Script executed:

#!/bin/bash
# Check for lock files that might already pin versions
echo "=== Looking for lock files ==="
find . -maxdepth 2 -type f \( -name "package-lock.json" -o -name "yarn.lock" \) -ls

echo ""
echo "=== Checking package.json structure and other dependencies ==="
head -30 oidc-ui/package.json

echo ""
echo "=== Checking for other caret-prefixed beta versions ==="
rg '"\^.*-beta' oidc-ui/package.json

Repository: mosip/esignet

Length of output: 1408


Pin the exact beta version to prevent unintended updates.

While the lock file currently freezes the installed version, using caret (^) with beta versions creates ambiguity about intent. If the lock file is regenerated or npm update runs, the caret allows resolution to 0.1.1-beta.7, 0.1.1-beta.8, etc.—which don't follow standard semver backward-compatibility guarantees. This risks breaking the Form.js API calls (render(), updateLanguage(), getFormData()).

For clarity and stability, pin the exact version:

-    "@mosip/json-form-builder": "^0.1.1-beta.6",
+    "@mosip/json-form-builder": "0.1.1-beta.6",

Note: The same pattern applies to @mosip/secure-biometric-interface-integrator.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"@mosip/json-form-builder": "^0.1.1-beta.6",
"@mosip/json-form-builder": "0.1.1-beta.6",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@oidc-ui/package.json` at line 7, Replace the caret-ranged beta dependency
entries so they pin exact versions: change "@mosip/json-form-builder":
"^0.1.1-beta.6" to an exact version string (e.g., "0.1.1-beta.6") and do the
same for "@mosip/secure-biometric-interface-integrator" to remove the leading
caret; update the package.json dependency values accordingly and run your
lockfile update (npm install / npm ci) to persist the pinned versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant