Skip to content

MOSIP-41353: Remove unused config files and properties in ESIGNET module.#1665

Open
SradhaMohanty5899 wants to merge 4 commits intomosip:developfrom
SradhaMohanty5899:MOSIP-41353
Open

MOSIP-41353: Remove unused config files and properties in ESIGNET module.#1665
SradhaMohanty5899 wants to merge 4 commits intomosip:developfrom
SradhaMohanty5899:MOSIP-41353

Conversation

@SradhaMohanty5899
Copy link
Contributor

@SradhaMohanty5899 SradhaMohanty5899 commented Mar 13, 2026

Performed cleanup of unused configuration files and properties in the ESIGNET API Test Rig module.

  • Verified all files under src/main/resources/config.
  • Removed unused configuration files where they were not referenced in the module.
  • Verified property usage in application.properties and removed unused entries.

Summary by CodeRabbit

  • Chores
    • Removed unused imports from test scripts to improve code quality.
    • Cleaned up obsolete configuration files and test data resources, streamlining the codebase.
    • Simplified configuration property mappings and removed outdated API endpoint references.

@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

Walkthrough

This pull request removes unused import statements from multiple test utility classes and deletes numerous configuration and resource files from the project. No functional logic, method signatures, or public API changes are introduced.

Changes

Cohort / File(s) Summary
Unused Imports Cleanup in Test Scripts
api-test/src/main/java/io/mosip/testrig/apirig/esignet/testscripts/AddIdentity.java, DeleteWithParam.java, EsignetBioAuth.java, GetWithParam.java, GetWithQueryParam.java, PatchWithPathParamsAndBody.java, PostWithAutogenIdWithOtpGenerate.java, PostWithBodyAndPathParams.java, PostWithBodyWithOtpGenerate.java, PostWithOnlyPathParam.java, PutWithPathParamsAndBody.java, SimplePost.java, SimplePatchForAutoGenId.java
Removed unused imports: java.lang.reflect.Field, org.testng.internal.BaseTestMethod, org.testng.internal.TestResult from each file. No behavioral changes.
Extended Import Cleanup
api-test/src/main/java/io/mosip/testrig/apirig/esignet/testscripts/PostWithAutogenIdWithOtpGenerateForWla.java, PostWithBodyAndQueryParamsForAutoGenId.java, SimplePostForAutoGenId.java, SimplePostForAutoGenIdForUrlEncoded.java
Removed unused test-related imports (3-5 per file including java.util.ArrayList, org.testng.annotations.AfterClass variations).
Cryptography & JWT Import Cleanup
api-test/src/main/java/io/mosip/testrig/apirig/esignet/utils/EsignetUtil.java
Removed 11 unused cryptographic and JWT-related imports: KeyPair, RSAPrivateKey, RSAPublicKey, JSONException, com.auth0.jwt.*, Gson, TypeToken, KeyUse.
Configuration & Policy JSON Files
api-test/src/main/resources/config/AuthPolicy4.json, AuthPolicy5.json, esignetPayload.json, errorUIN.json, errorUINIdp.json, errorUINKyc.json, bulkUpload.json, clientPrivateKey.txt, sign.json, prereg_SendOtp.json, prereg_ValidateOtp.json
Deleted 11 configuration and test payload resource files. No code references identified in diff.
Large Property Configuration Files
api-test/src/main/resources/config/IDRepo.properties, IDRepo2.properties, IDjson.properties, adminQueries.properties, partnerQueries.properties
Deleted 5 large property files containing API endpoint mappings, SQL test data fixtures, and authentication configuration (86–908 lines each). Removal eliminates predefined test data setup/teardown sequences.
API & Token Endpoint Configuration
api-test/src/main/resources/config/UmcValidationApis.properties, adminTokenGeneration.properties, idRepoToken.properties, registrationProcessorAPI.properties
Deleted endpoint mappings, token request parameters, HDFS credentials, and API paths. Removed environment-specific encryption port configurations.
Path & Mapping Configuration
api-test/src/main/resources/config/folderPaths.properties, mapping.properties, packetProperties.properties, packetValidator.properties, partnerDemoService.properties
Removed folder path definitions, authentication request mappings, packet property keys, and encryption port entries. Includes test script mapping blocks for BioAuth and EkyC workflows.
Miscellaneous Configuration
api-test/src/main/resources/config/application.properties, test.properties, updatePacketProperties.properties, residentServicesQueries.properties
Removed most application properties (keeping only codeVerifier), environment test variables, packet update property mappings, and SQL registration packet creation/deletion statements.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 With twitching nose and careful eye,
We snipped the imports way up high,
And swept clean configs left behind,
A tidy codebase, now refined! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: removal of unused config files and properties from the ESIGNET module, which aligns perfectly with the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes with custom instructions.

Set the reviews.auto_title_instructions setting to generate a title for your PR based on the changes in the PR with custom instructions.

@SradhaMohanty5899 SradhaMohanty5899 changed the title Mosip 41353 MOSIP-41353: Remove unused config files and properties in ESIGNET module. Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant