Skip to content

ES-2842 | increased the leeway seconds to 15#1652

Open
nandhu-kumar wants to merge 1 commit intomosip:developfrom
nandhu-kumar:es-2842
Open

ES-2842 | increased the leeway seconds to 15#1652
nandhu-kumar wants to merge 1 commit intomosip:developfrom
nandhu-kumar:es-2842

Conversation

@nandhu-kumar
Copy link
Contributor

@nandhu-kumar nandhu-kumar commented Mar 2, 2026

Summary by CodeRabbit

  • Chores
    • Increased JWT validation leeway for client assertions from 5 to 15 seconds, enhancing flexibility in timing validation during client authentication processes.

Signed-off-by: Nandhukumar <nandhukumare@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9938969 and b7fcbb8.

📒 Files selected for processing (1)
  • esignet-service/src/main/resources/application-default.properties

Walkthrough

A configuration parameter in the application properties file was updated to increase the JWT validation leeway for client assertions from 5 seconds to 15 seconds, adjusting the timing tolerance for exp/nbf claim validation.

Changes

Cohort / File(s) Summary
JWT Validation Configuration
esignet-service/src/main/resources/application-default.properties
Updated client assertion JWT exp/nbf validation leeway from 5 seconds to 15 seconds.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A leeway that grew with the seasons,
Five seconds became fifteen, for good reasons,
JWT claims now dance with more time,
The validation waltz, perfectly sublime! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: increasing the JWT assertion leeway from 5 to 15 seconds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant