[ES-2914] build action failure in sun bird plugin due to inclusion/exclusion str…

[Md-Humair-KK]

…ategies

Summary by CodeRabbit

• Chores
  • Integrated code quality scanning into the build process to enhance code standards and maintainability.

[coderabbitai]

Walkthrough

Adds SonarQube integration to the Maven build configuration by introducing a sonar profile with plugin properties and code analysis exclusion rules. This enables automated code quality scanning during the verify phase when the profile is activated.

Changes

Cohort / File(s)	Summary
SonarQube Maven Integration sunbird-rc-plugin/pom.xml	Added maven.sonar.plugin.version property and three sonar exclusion properties (sonar.exclusions, sonar.cpd.exclusions, sonar.coverage.exclusions). Created new sonar profile that configures sonar-maven-plugin to execute during verify phase with SonarCloud endpoint.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 Hops of joy through code so clean,
SonarQube's the best I've seen!
Quality checks now in the blend,
Bug detection—our trusted friend! 🎯

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is truncated/incomplete, ending with '…' mid-word ('str…'), making it unclear what specific inclusion/exclusion strategy issue is being addressed.	Complete the pull request title to fully describe the inclusion/exclusion strategy issue being resolved (e.g., 'SonarQube inclusion/exclusion strategies' or similar).

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can suggest fixes for GitHub Check annotations.

Configure the reviews.tools.github-checks setting to adjust the time to wait for GitHub Checks to complete.

[coderabbitai]

🧹 Nitpick comments (1)

sunbird-rc-plugin/pom.xml (1)

350-354: Decouple analysis exclusions from coverage exclusions.

At Line 353, sonar.exclusions is bound to ${sonar.coverage.exclusions}. That makes the dedicated sonar.exclusions declared at Line 85 effectively unused and couples two strategies that are usually tuned independently.

Suggested cleanup

 			<properties>
 				<sonar.sources>.</sonar.sources>
 				<sonar.inclusions>src/main/java/**,src/main/resources/**</sonar.inclusions>
-				<sonar.exclusions>${sonar.coverage.exclusions}</sonar.exclusions>
 				<sonar.host.url>https://sonarcloud.io</sonar.host.url>
 			</properties>

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@sunbird-rc-plugin/pom.xml` around lines 350 - 354, The sonar.exclusions
property is incorrectly set to ${sonar.coverage.exclusions}, coupling general
analysis exclusions with coverage-specific exclusions; change the
sonar.exclusions declaration so it uses its own explicit value or references the
intended property (remove the link to sonar.coverage.exclusions) so the separate
sonar.exclusions defined elsewhere is honored—update the <properties> block
where sonar.exclusions is assigned and ensure sonar.coverage.exclusions remains
a distinct property.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@sunbird-rc-plugin/pom.xml`:
- Around line 350-354: The sonar.exclusions property is incorrectly set to
${sonar.coverage.exclusions}, coupling general analysis exclusions with
coverage-specific exclusions; change the sonar.exclusions declaration so it uses
its own explicit value or references the intended property (remove the link to
sonar.coverage.exclusions) so the separate sonar.exclusions defined elsewhere is
honored—update the <properties> block where sonar.exclusions is assigned and
ensure sonar.coverage.exclusions remains a distinct property.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 53f6ff21-34b8-47b1-a4a0-3f241a062716

📥 Commits

Reviewing files that changed from the base of the PR and between da49f0e and 5ea89f9.

📒 Files selected for processing (1)

• sunbird-rc-plugin/pom.xml