Skip to content

Training on PQ shards#443

Open
knighton wants to merge 12 commits intomainfrom
james/pq
Open

Training on PQ shards#443
knighton wants to merge 12 commits intomainfrom
james/pq

Conversation

@knighton
Copy link
Copy Markdown
Contributor

Description of changes:

Issue #, if available:

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

@knighton knighton changed the title [WIP] Training on PQ Training on PQ shards Sep 23, 2023
Comment thread streaming/base/format/pq/reader.py Outdated
Comment thread streaming/base/format/pq/reader.py
Returns:
int: Change in cache usage in bytes due to PQ -> MDS conversion.
"""
pq_filename = os.path.join(self.dirname, self.split, self.raw_parquet.basename)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prepare the complete parquet file can hurt initialization time. A better approach is to downloading one row group at a time on the fly. It should not significantly affect the overall design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants