Skip to content

Adds certoraCVLFormatter into workflow#902

Draft
bhargavbh wants to merge 2 commits intomainfrom
certora/add-linter
Draft

Adds certoraCVLFormatter into workflow#902
bhargavbh wants to merge 2 commits intomainfrom
certora/add-linter

Conversation

@bhargavbh
Copy link
Copy Markdown
Contributor

@bhargavbh bhargavbh commented Mar 6, 2026

Adds certoraCVLFormatter into workflow for Certora Specs

@bhargavbh
Copy link
Copy Markdown
Contributor Author

bhargavbh commented Mar 6, 2026

Only the Reverts.spec has multi-line boolean conditions which we may want to preserve for readability.
We can decide either to add the CertoraCVLFormatter check only for changed spec files for now or change all the existing specs to adhere to the format.

Comment on lines +84 to +87
if [ "${{ github.event_name }}" = "pull_request" ]; then
git fetch origin ${{ github.base_ref }} --depth=1
git diff --name-only origin/${{ github.base_ref }}...HEAD | grep -qF "$file" || exit 0
fi
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if [ "${{ github.event_name }}" = "pull_request" ]; then
git fetch origin ${{ github.base_ref }} --depth=1
git diff --name-only origin/${{ github.base_ref }}...HEAD | grep -qF "$file" || exit 0
fi

as discussed let's do this (and fix the formatting errors)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants