Skip to content

[Certora] accrueInterestView revert conditions#897

Merged
QGarchery merged 29 commits intomainfrom
certora/accrueInterestViewRevert
Mar 12, 2026
Merged

[Certora] accrueInterestView revert conditions#897
QGarchery merged 29 commits intomainfrom
certora/accrueInterestViewRevert

Conversation

@bhargavbh
Copy link
Copy Markdown
Contributor

constraints on variables can probably be improved.

@bhargavbh bhargavbh self-assigned this Mar 3, 2026
@bhargavbh bhargavbh marked this pull request as ready for review March 3, 2026 08:19
@bhargavbh
Copy link
Copy Markdown
Contributor Author

bhargavbh commented Mar 3, 2026

The bidirectional equivalence (conditions <=> lastReverted) is very tricky to prove because quite a few bounds are in decimal exponents and other in binary exponents and offset by one issues. Moreover, the precise conditions would be relations over parameter rather than individual parameter inequalities.
Hence, the rule only shows GoodConditions => !lastReverted, which is the direction required for the canForceDeallocateZero rule.

@bhargavbh bhargavbh changed the title accrueINterestView revert conditions accrueInterestView revert conditions Mar 3, 2026
@bhargavbh bhargavbh requested review from MathisGD and QGarchery March 3, 2026 13:37
Comment thread certora/specs/Reverts.spec Outdated
Comment thread certora/specs/Reverts.spec Outdated
Comment thread certora/specs/Reverts.spec Outdated
Comment thread certora/specs/Reverts.spec Outdated
Comment thread certora/specs/Reverts.spec Outdated
Comment thread certora/specs/Reverts.spec Outdated
bhargavbh and others added 10 commits March 3, 2026 15:47
Co-authored-by: Quentin Garchery <garchery.quentin@gmail.com>
Signed-off-by: Bhargav Bhatt <40268131+bhargavbh@users.noreply.github.com>
Co-authored-by: Quentin Garchery <garchery.quentin@gmail.com>
Signed-off-by: Bhargav Bhatt <40268131+bhargavbh@users.noreply.github.com>
Co-authored-by: Quentin Garchery <garchery.quentin@gmail.com>
Signed-off-by: Bhargav Bhatt <40268131+bhargavbh@users.noreply.github.com>
@bhargavbh bhargavbh changed the title accrueInterestView revert conditions [Certora] accrueInterestView revert conditions Mar 12, 2026
Comment thread certora/specs/AccrueInterestReverts.spec Outdated
Comment thread certora/specs/AccrueInterestReverts.spec
Comment thread certora/specs/AccrueInterestReverts.spec
Comment thread certora/specs/AccrueInterestReverts.spec
Comment thread certora/specs/AccrueInterestReverts.spec
Comment thread certora/specs/AccrueInterestReverts.spec
Copy link
Copy Markdown
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! interesting that maxMaxRate plays a big role here

@QGarchery QGarchery merged commit caeb79c into main Mar 12, 2026
49 checks passed
@QGarchery QGarchery deleted the certora/accrueInterestViewRevert branch March 12, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants