feat(controller): Implement controller commands#2
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new controller command group to the CLI for interacting with a morpher controller, including ping and info subcommands. The implementation provides HTTP client functionality with authentication support and comprehensive test coverage.
- Added controller CLI commands (
controller pingandcontroller info) for checking connectivity and retrieving controller information - Implemented HTTP client with authentication, timeout configuration, and health check capabilities
- Added comprehensive unit test suite covering client creation, HTTP requests, and authorization handling
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/root.go | Registers the new controller command group |
| cmd/controller/controller.go | Defines the main controller command group |
| cmd/controller/ping.go | Implements ping subcommand for connectivity checks |
| cmd/controller/info.go | Implements info subcommand for retrieving controller details |
| internal/controller/client.go | HTTP client implementation with configuration management |
| internal/controller/client_test.go | Comprehensive test suite for the controller client |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fb4da75 to
6af01ba
Compare
6af01ba to
86eb1a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new controller command group to the CLI, allowing users to interact with a "morpher controller" via subcommands for pinging and retrieving information. It also adds a comprehensive client implementation for communicating with the controller, along with a full suite of unit tests for the client. The most important changes are grouped below:
CLI Command Additions
controllercommand group withpingandinfosubcommands, enabling users to check connectivity and retrieve controller details from the CLI (cmd/controller/controller.go,cmd/controller/ping.go,cmd/controller/info.go). [1] [2] [3]controllercommand group in the root CLI command, making it available to users (cmd/root.go). [1] [2]Controller Client Implementation
Clientininternal/controller/client.goto handle HTTP communication with the controller, including methods for ping, info retrieval, health checks, and configuration management.Testing
internal/controller/client_test.go).