Skip to content

[codex] update smoke binary names#20

Merged
kixelated merged 3 commits into
mainfrom
codex/update-smoke-binary-names
Jul 4, 2026
Merged

[codex] update smoke binary names#20
kixelated merged 3 commits into
mainfrom
codex/update-smoke-binary-names

Conversation

@kixelated

Copy link
Copy Markdown
Contributor

Summary

Updates the smoke harness for the Rust CLI executable rename: the moq-cli package now installs/runs as moq, and the moq-token-cli package now installs/runs as moq-token.

What Changed

  • Default media smoke tests to moq instead of resolving or reporting moq-cli.
  • Default token interop tests to moq-token.
  • Point CI and the Nix-channel wrapper at bin/moq and bin/moq-token.
  • Rename the Docker-channel wrapper from clients/docker/moq-cli to clients/docker/moq, while preserving the published moqdev/moq-cli image name.
  • Update docs and freshness checks so package/image identifiers remain distinct from executable names.
  • Require the npm @moq/token package to expose the moq-token bin.

Impact

The smoke tests now exercise the renamed binaries users will have on PATH, while continuing to install and verify the same package, crate, Nix attribute, and Docker image channels.

Validation

  • bash -n smoke.sh token.sh freshness.sh clients/docker/moq clients/docker/moq-relay
  • ./freshness.sh
  • git diff --check
  • node --check clients/token/js/resolve-bin.mjs

just check could not be run in this shell because just is not installed; the available underlying checks above passed.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @kixelated, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@kixelated kixelated force-pushed the codex/update-smoke-binary-names branch from 1418e2f to 8e96bc1 Compare July 4, 2026 02:30
@kixelated kixelated marked this pull request as ready for review July 4, 2026 02:30

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @kixelated, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@kixelated, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9fcdbf39-13d4-497c-a079-db366e3e2527

📥 Commits

Reviewing files that changed from the base of the PR and between 8e96bc1 and 3055121.

📒 Files selected for processing (3)
  • README.md
  • smoke.sh
  • token.sh

Walkthrough

This pull request renames referenced binaries from moq-cli/moq-token-cli to moq/moq-token across the smoke-test tooling. Changes span the CI workflow, smoke.sh, token.sh, justfile, Docker wrapper scripts, resolve-bin.mjs, freshness.sh, flake.nix, and README.md. Updates include binary resolution logic in require_tools(), MOQ_BIN/TOKEN_BIN environment variable values, install step labels, log/error messages, code comments, and documentation examples/tables reflecting the new binary names.

Changes

Cohort / File(s) Summary
smoke.sh, token.sh Resolve moq/moq-token binaries by default; updated comments, error messages, and log output.
clients/docker/moq, clients/docker/moq-relay, freshness.sh Docker wrapper comments and freshness pin-check path updated for moq naming.
justfile Comments and nix-channel MOQ_BIN path/echo updated to moq.
.github/workflows/smoke.yml Install step labels, MOQ_BIN/TOKEN_BIN exports, and token interop comments updated.
clients/token/js/resolve-bin.mjs Removed fallback to moq-token-cli bin entry.
flake.nix Comment updated to reference moq.
README.md Tables, examples, and status bullets updated for moq/moq-token.

Sequence Diagram(s)

Not applicable; changes are naming/documentation updates without new control flow.

Related PRs: None identified.

Suggested labels: documentation, ci, refactor

Suggested reviewers: moq-dev/maintainers

🐰 A rabbit hops through scripts anew,
Trading "cli" for names more true,
moq now stands both lean and plain,
token too sheds its old refrain,
Comments and docs all sing along — 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: updating smoke binary names.
Description check ✅ Passed The description accurately matches the PR's smoke harness, CI, docs, and token binary rename updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch codex/update-smoke-binary-names

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated kixelated merged commit f7a4b1b into main Jul 4, 2026
5 checks passed
@kixelated kixelated deleted the codex/update-smoke-binary-names branch July 4, 2026 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant