Skip to content

Remove the Type object from the public API#2825

Open
AmraniCh wants to merge 1 commit intomootools:masterfrom
AmraniCh:hide-type-object
Open

Remove the Type object from the public API#2825
AmraniCh wants to merge 1 commit intomootools:masterfrom
AmraniCh:hide-type-object

Conversation

@AmraniCh
Copy link
Copy Markdown

First, I want to congratulate you all on working so hard for making this great library.

Summary

When I was looking in the Core.js I've noticed that the Type object is not mentioned in the Mootools official documentation in the core section (except once used in one example on the Array page), although it is available to the end-users. The Type object offers only the Type.is[Type] functions to check the passed object type, which can be achieved using the Mootools typeOf function or even using the TypeInstance.$family function that injected to all the native JavaScript types defined by ECMA spec.

Suggestion

The Type object must be for the internal usage only, In order to clear up any confusion for library users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant