Skip to content

Fix #2428 IE8: Fx.Morph percentage unit issue#2477

Open
gmaes wants to merge 1 commit intomootools:masterfrom
gmaes:master
Open

Fix #2428 IE8: Fx.Morph percentage unit issue#2477
gmaes wants to merge 1 commit intomootools:masterfrom
gmaes:master

Conversation

@gmaes
Copy link
Copy Markdown

@gmaes gmaes commented Mar 15, 2013

This pull request fixes the unit issue in the Fx.CSS class.
Indeed, we can not morph a property using a specific unit (let say %) and a color property at the same time.
This example fails:

el.set("morph", {
    "duration": 1000,
    "unit": "%"
});
el.get("morph").start({
    "height": "50",
    "background-color": "#00FF00"
});

The animation on the background-color does not work.

@gonchuki
Copy link
Copy Markdown
Member

I like it.
Could you add some tests for this fix?

@ibolmo ibolmo added this to the 1.5.1 milestone Mar 3, 2014
@SergioCrisostomo
Copy link
Copy Markdown
Member

Example of the broken behaviour: http://jsfiddle.net/Ss8k2/2/

This PR is a good step to fix this but fixes only partially the problem: http://jsfiddle.net/Ss8k2/

@SergioCrisostomo SergioCrisostomo modified the milestones: 1.5.2, 1.5.1 Jul 3, 2014
@ibolmo
Copy link
Copy Markdown
Member

ibolmo commented Nov 11, 2014

I'm going to defer this for 1.6. This may resolve itself with #2503.

@ibolmo ibolmo modified the milestones: 1.6.0, 1.5.2 Nov 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants