Skip to content

refactor: enable source maps for running executable#1482

Merged
peter-jerry-ye merged 3 commits intomainfrom
zihang/adjust-sourcemaps
Feb 26, 2026
Merged

refactor: enable source maps for running executable#1482
peter-jerry-ye merged 3 commits intomainfrom
zihang/adjust-sourcemaps

Conversation

@peter-jerry-ye
Copy link
Copy Markdown
Contributor

@peter-jerry-ye peter-jerry-ye commented Feb 14, 2026

  • Related issues: None
  • PR kind: optimization

Summary

Always enable sourcemaps even for running moon run --target js.

The rational is that we are adding mangling for all the symbols. Not using sourcemap would make the backtrace almost useless.

Metadata

  • Tests added/updated for bug fixes or new features
  • Compatible with Windows/Linux/macOS

@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Feb 14, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  crates/moon/src/run/runtime.rs  34% smaller
  crates/moonutil/src/demangle.rs  19% smaller
  crates/moonrun/src/template/demangle.js  9% smaller
  crates/moon/tests/test_cases/native_abort_trace/mod.rs  7% smaller
  crates/moon/tests/test_cases/mod.rs  0% smaller
  crates/moon/tests/test_cases/target_backend/mod.rs  0% smaller
  crates/moonrun/src/demangle_js_template.rs  0% smaller
  crates/moonrun/tests/test.rs  0% smaller

@peter-jerry-ye peter-jerry-ye requested a review from Yu-zh February 14, 2026 08:47
@peter-jerry-ye peter-jerry-ye force-pushed the zihang/adjust-sourcemaps branch from feca59b to c9d59a1 Compare February 26, 2026 07:51
@peter-jerry-ye peter-jerry-ye merged commit ed55d30 into main Feb 26, 2026
8 of 11 checks passed
@peter-jerry-ye peter-jerry-ye deleted the zihang/adjust-sourcemaps branch February 26, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants