Conversation
|
Review changes with Changed Files
|
tonyfettes
force-pushed
the
haoxiang/test-timeout
branch
from
1fc4485 to
fef11b2
Compare
|
@codex Review? |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fef11b2d3b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /// Test timeout in seconds | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| #[serde(alias = "test-timeout")] | ||
| #[schemars(rename = "test-timeout")] | ||
| pub test_timeout: Option<u64>, |
There was a problem hiding this comment.
Adding MoonPkgJSON::test_timeout changes the generated package schema, but this change does not include the corresponding regenerated artifacts (crates/moonbuild/template/pkg.schema.json and the manual schema HTML files) that validate_pkg_json_schema checks in crates/moonutil/src/package.rs; this will make that test fail once CI runs and leaves user-facing schema docs out of sync with the code.
Useful? React with 👍 / 👎.
| let test_timeout = cmd.timeout.or_else(|| { | ||
| // Try to get timeout from the first package's configuration | ||
| build_meta | ||
| .resolve_output | ||
| .pkg_dirs | ||
| .all_packages() | ||
| .next() |
There was a problem hiding this comment.
When --timeout is omitted, this code takes test_timeout from pkg_dirs.all_packages().next(), so in multi-package projects (or with --package filters) the timeout can come from an unrelated package and then be applied globally to all test executables; this makes moon.pkg.json timeout behavior incorrect for any package that is not first in discovery order.
Useful? React with 👍 / 👎.
2 participants
moon test#1290Summary
This PR closes #1290, adding timeout support in
moon testcommand line andmoon.pkg.jsonconfiguration file.Metadata