Avoid exception and console error message when SKCanvasView is created and then immediately disposed in Blazor#3427
Avoid exception and console error message when SKCanvasView is created and then immediately disposed in Blazor#3427
Conversation
… and then immediately disposed. In javascript methods, return earlier when element is not available in DOM, also remove the error message in same scenario. In Balazor, the elements are removed from DOM before calling Dispose() of the component. So after each async method, the DOM element may be removed due to navigate to other node. No simple way to detect if the missing element is because the component is disposed, or software logic error. Ref: dotnet/aspnetcore#45777
jjzhang12
changed the title
|
Thanks @@jjzhang12! , for adding this fix. Could this change be merged? It will help resolve the key exceptions. @mattleibow - Could you please review and approve @jjzhang12 ’s change so it can be merged? |
|
@mattleibow - Could this fix please be integrated ASAP? This bug causes notable usability issues since the errors it causes cannot be easily suppressed as a workaround to prevent the Blazor error UI from being displayed. Many thanks! |
📦 Try the packages from this PRWarning Do not run these scripts without first reviewing the code in this PR. Step 1 — Download the packages bash / macOS / Linux: curl -fsSL https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.sh | bash -s -- 3427PowerShell / Windows: iex "& { $(irm https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.ps1) } 3427"Step 2 — Add the local NuGet source dotnet nuget add source ~/.skiasharp/hives/pr-3427/packages --name skiasharp-pr-3427More options
Or download manually from Azure Pipelines — look for the Remove the source when you're done: dotnet nuget remove source skiasharp-pr-3427 |
3 participants
Description of Change
In JavaScript methods, return early when the target element is no longer present in the DOM, and remove the related error log for this scenario.
In Blazor, elements can be removed from the DOM before a component’s Dispose() method is invoked. This means that after any async call, the corresponding DOM element may already have been removed due to navigation. There’s no reliable way to distinguish whether a missing element is due to normal component disposal or an actual logic error. This change updates the code to simply stop execution when the element is absent and suppress error logging for this case.
Ref: dotnet/aspnetcore#45777
Bugs Fixed
#3322
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist