Add configurable query timeout for model document queries#208
Draft
vkarpov15 wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
10seconds stored understudio:model-query-timeout-secondsand exposed in the models UI asQuery Timeout: X secondsin the 3-dot menu (opens a modal to edit and persist the value).maxTimeMSto the params produced bybuildDocumentFetchParams()infrontend/src/models/models.jsand passingmaxTimeMSto API calls such asModel.getDocumentsand streamed fetches.maxTimeMSparameter inModel.getDocumentsandModel.getDocumentsStreamand apply it via Mongoose'squery.maxTimeMS()when provided and > 0.frontend/src/models/models.jsand markup infrontend/src/models/models.htmlto configure the timeout.Testing
npm run lintand it completed successfully.npm test -- --grep "Model.getDocuments()"but tests failed to run in this environment due to no MongoDB available (error: connection refused to127.0.0.1:27017).Codex Task