Migrate Danger to danger-pr-comment workflow#259
Open
dblock wants to merge 8 commits intomongoid:masterfrom
Open
Migrate Danger to danger-pr-comment workflow#259dblock wants to merge 8 commits intomongoid:masterfrom
dblock wants to merge 8 commits intomongoid:masterfrom
Conversation
dblock
force-pushed
the
danger-pr-comment
branch
from
e58b6fc to
57b7f82
Compare
12 tasks
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock
force-pushed
the
danger-pr-comment
branch
from
57b7f82 to
7a36296
Compare
- Add racc gem dependency (required for Ruby 3.0+) - Add psych < 5.0 constraint for compatibility with older gems - Upgrade rubocop from 0.49.0 to 1.28 (last version supporting Ruby 2.5) These changes fix LoadError for racc/parser and YAML.safe_load argument errors when using Ruby 3.3+ with older gem dependencies.
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock
force-pushed
the
danger-pr-comment
branch
from
d64d1f3 to
24eb945
Compare
dblock
force-pushed
the
danger-pr-comment
branch
from
7137506 to
e4bc4aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the Danger workflow from the deprecated
mongoid-dangergem to the moderndanger-pr-commentworkflow. This change improves the PR review process by running Danger checks via GitHub Actions and posting comments directly on pull requests.Changes
GitHub Actions Workflows
.github/workflows/danger.yml- Runs Danger checks on pull request events.github/workflows/danger-comment.yml- Posts Danger comments after checks completeDependencies
mongoid-dangergemdanger,danger-pr-comment, anddanger-changeloggemspsych < 5.0to address compatibility issuesrubocopfrom~> 0.49.0to~> 1.28Dangerfile
danger-pr-commentplugin instead ofmongoid-dangerchangelog.check!to verify CHANGELOG.md updatesCI/Test Configuration
.github/workflows/test.ymlto use Ruby 2.7 as minimum version (was 2.3-2.6)Code Quality
.rubocop_todo.ymlwith latest Rubocop 1.82.1 offensesDocumentation
Test Plan
References
This follows the same migration pattern as:
🤖 Generated with Claude Code