Skip to content

DRIVERS-3218 clarify label handling#1892

Merged
kevinAlbs merged 2 commits intomongodb:masterfrom
kevinAlbs:clarify-backpressure-labels
Feb 6, 2026
Merged

DRIVERS-3218 clarify label handling#1892
kevinAlbs merged 2 commits intomongodb:masterfrom
kevinAlbs:clarify-backpressure-labels

Conversation

@kevinAlbs
Copy link
Copy Markdown
Contributor

@kevinAlbs kevinAlbs commented Feb 6, 2026

Summary

This PR clarifies two points related to DRIVERS-3218. No behavioral changes are intended.

  • Add the RetryableError error label to example code.

  • Clarify non-backpressure errors should not add the backpressure label.

    • The current wording says "MUST clear the connection pool and MUST mark the server Unknown". However SDAM error handling includes more behaviors (e.g. canceling a server check). This is changed to "MUST NOT add the backpressure error labels", which I expect is the intended implementation.

Please complete the following before merging:

  • Is the relevant DRIVERS ticket in the PR title?
  • [ ] Update changelog. N/A Clarifications only.
  • [ ] Test changes in at least one language driver. N/A Clarifications only.
  • [ ] Test these changes against all server versions and topologies (including standalone, replica set, and sharded
    clusters).
    N/A Clarifications only.

Matches the above text under "backpressure-enabled" and the PyMongo implementation.
@kevinAlbs kevinAlbs force-pushed the clarify-backpressure-labels branch from 21433eb to 5e04731 Compare February 6, 2026 01:44
@kevinAlbs kevinAlbs force-pushed the clarify-backpressure-labels branch from 5e04731 to 69c1449 Compare February 6, 2026 01:45
@kevinAlbs kevinAlbs requested a review from blink1073 February 6, 2026 14:50
@kevinAlbs kevinAlbs marked this pull request as ready for review February 6, 2026 14:50
@kevinAlbs kevinAlbs requested a review from a team as a code owner February 6, 2026 14:50
@kevinAlbs kevinAlbs requested review from BorisDog and removed request for a team February 6, 2026 14:50
Copy link
Copy Markdown
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kevinAlbs kevinAlbs removed the request for review from BorisDog February 6, 2026 20:15
@kevinAlbs kevinAlbs merged commit bb9dddd into mongodb:master Feb 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants