DO NOT MERGE: Review discussion points for NODE-7122 #4818
+46
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
commented
Dec 3, 2025
|
|
||
| // 6.ii (cont.) If elapsed time + backoffMS > TIMEOUT_MS, then raise last known error | ||
| // DP: the lines above do this math slightly indirectly, but this break does NOT raise the last known error | ||
| // because breaking the while loop takes us to the return result statement outside the while(!committed) |
Contributor
Author
There was a problem hiding this comment.
actually, to the top of the for retry loop (but with the same effect re: last known error)
dariakp
commented
Dec 3, 2025
| } | ||
|
|
||
| // 6.ii (cont.) Otherwise, sleep for backoffMS, increment retry, and jump back to step two. | ||
| // DP: Assuming the spec means step 8 |
Contributor
Author
There was a problem hiding this comment.
if the spec means 2, this is correct
dariakp
commented
Dec 3, 2025
|
|
||
| // 9.ii If the commitTransaction error includes a "TransientTransactionError" label | ||
| // and the elapsed time of withTransaction is less than TIMEOUT_MS, jump back to step two. | ||
| // DP: Step two makes no sense here, perhaps the intent is to perform the instructions in 6.ii and then jump back to 8? |
Contributor
Author
There was a problem hiding this comment.
if my comment is correct, then this is ok here, but needs to also be in 6.ii
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Notes for Reviewers
What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript