Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mmcclimon
requested changes
Mar 26, 2026
Contributor
mmcclimon
left a comment
There was a problem hiding this comment.
I'm fine with this in theory but this not actually seem to work, according to Evergreen.
38db67a to
0dfbfe9
Compare
Collaborator
Author
|
Yeah, it turns out the default shell is |
…e same `set` directives
set -o errexit
set -o pipefail
set -o verbose
This also updates all these scripts to use `bash` as their shell.
0dfbfe9 to
e91747a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Now most scripts start with:
There were a few spots where error checking needs to be off because the commands we run are expect to fail sometimes.