Skip to content

Update every embedded script in the Evergreen config to start with the same set directives#963

Open
autarch wants to merge 1 commit intomasterfrom
03-26-update_every_embedded_script_in_the_evergreen_config_to_start_with_the_same_set_directives
Open

Update every embedded script in the Evergreen config to start with the same set directives#963
autarch wants to merge 1 commit intomasterfrom
03-26-update_every_embedded_script_in_the_evergreen_config_to_start_with_the_same_set_directives

Conversation

@autarch
Copy link
Collaborator

@autarch autarch commented Mar 26, 2026

Now most scripts start with:

set -o errexit
set -o pipefail
set -o verbose

There were a few spots where error checking needs to be off because the commands we run are expect to fail sometimes.

@autarch autarch requested a review from a team as a code owner March 26, 2026 18:38
@autarch autarch requested review from mmcclimon and removed request for a team March 26, 2026 18:38
Copy link
Collaborator Author

autarch commented Mar 26, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

@mmcclimon mmcclimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this in theory but this not actually seem to work, according to Evergreen.

@autarch autarch force-pushed the 03-26-update_every_embedded_script_in_the_evergreen_config_to_start_with_the_same_set_directives branch from 38db67a to 0dfbfe9 Compare March 26, 2026 18:54
Copy link
Collaborator Author

autarch commented Mar 26, 2026

Yeah, it turns out the default shell is sh, not bash, so we need to set that too 😢

…e same `set` directives

    set -o errexit
    set -o pipefail
    set -o verbose

This also updates all these scripts to use `bash` as their shell.
@autarch autarch force-pushed the 03-26-update_every_embedded_script_in_the_evergreen_config_to_start_with_the_same_set_directives branch from 0dfbfe9 to e91747a Compare March 26, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants