Skip to content

TOOLS-4148 Add another task to the AI plan for converting JS tests to Go #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
autarch wants to merge 1 commit into from
+29 −0
Closed

TOOLS-4148 Add another task to the AI plan for converting JS tests to Go #950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .ai-plans/2026-03-13/js-to-go-test-migration/plan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,6 +1038,34 @@ git commit -m "migration: remove JS test infrastructure (resmoke, run_qa.sh, com

---

### Task 15: Refactor test helpers

After all conversions are complete, review all new test code for repeated patterns and extract them into shared package-level helper functions.

- [ ] **Step 1: Audit new test code for repetition** — scan all new test functions in `mongoimport`, `mongoexport`, `mongodump`, `mongorestore`, `mongofiles`, `mongostat`, `mongotop`, and `bsondump` for repeated code. Common patterns to look for:
- Export-then-drop-then-import sequences (already partially extracted)
- Tool options setup boilerplate
- Temp file creation and cleanup
- Collection count + drop assertions
- Session/client setup

- [ ] **Step 2: Extract helpers** — move repeated logic into named package-level functions. Keep helpers close to their callers (same file or a `_helpers_test.go` file if shared across multiple test files in the same package). If they're shared across packages, add them to the `common/testutil` package.

- [ ] **Step 3: Run full test suite** to confirm nothing broke.

```bash
go run build.go test:unit
TOOLS_TESTING_INTEGRATION=1 go run build.go test:integration
```

- [ ] **Step 4: Commit**

```bash
git commit -m "migration: refactor repeated patterns in converted test code"
```

---

## Summary of Batches

| Batch | Task | JS files | Go target | Status | Notes |
Expand All @@ -1057,6 +1085,7 @@ git commit -m "migration: remove JS test infrastructure (resmoke, run_qa.sh, com
| 12 | SSL/TLS | 2 | new SSL/TLS integration test files | | 2 NEW; manual env setup required |
| 13 | legacy42 | 34 | Various | | 4 SKIP, 20 NEW, 10 EXTEND |
| 14 | Cleanup | — | `common.yml`, `build.go`, `scripts/` | | Remove infrastructure |
| 15 | Refactor test helpers | — | All new test files | | Extract repeated patterns into shared helpers |

**Consistent SKIPs across all batches:**
- Broken pipe tests — OS-signal behavior, untestable in Go unit/integration tests
Expand Down