RUST-1054 SOCKS5 Proxy Support #1550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelatkinson
force-pushed
the
socks5
branch
from
230dd3c to
b24a009
Compare
isabelatkinson
commented
Dec 4, 2025
| @@ -33,40 +36,129 @@ pub(crate) enum AsyncStream { | |||
| Tcp(TcpStream), | |||
|
|
|||
| /// A TLS connection over TCP. | |||
| Tls(TlsStream), | |||
| Tls(TlsStream<TcpStream>), | |||
Contributor
Author
There was a problem hiding this comment.
I used concrete types in the TLS variants rather than a unified one with a generic bound because doing so would propagate generics to every type that uses a connection.
abr-egn
approved these changes
Dec 9, 2025
| /// Dummy struct for internal use. | ||
| #[cfg(not(feature = "socks5-proxy"))] | ||
| #[derive(Clone, Debug)] | ||
| pub(crate) struct Socks5Proxy; |
Contributor
There was a problem hiding this comment.
I'm guessing this is to avoid having to annotate every single place that just passes one of these around with #[cfg(feature = "socks5-proxy")] - handy. Going to remember this technique.
This was referenced Dec 9, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1054