Skip to content

PYTHON-5808 Drop support for MongoDB 4.2#2892

Draft
blink1073 wants to merge 4 commits into
mongodb:masterfrom
blink1073:PYTHON-5808
Draft

PYTHON-5808 Drop support for MongoDB 4.2#2892
blink1073 wants to merge 4 commits into
mongodb:masterfrom
blink1073:PYTHON-5808

Conversation

@blink1073

Copy link
Copy Markdown
Member

PYTHON-5808

Changes in this PR

Drops MongoDB 4.2 support, making MongoDB 4.4 (wire version 9) the new minimum. Removes dead code paths that only applied to pre-4.2 servers.

Test Plan

Standard test suite.

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)?
  • Is there test coverage?
  • Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

Bump minimum supported server version to MongoDB 4.4 (wire version 9).
Remove dead code paths that only applied to wire version < 8 servers,
including the legacy OP_GET_MORE protocol, the use_command dispatch
mechanism, and the from_command response field.
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pymongo/asynchronous/aggregation.py 0.00% 0 Missing and 1 partial ⚠️
pymongo/synchronous/aggregation.py 0.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Update post-42-*.json SDAM error fixtures and test_wire_version to use
wire version 9 (MongoDB 4.4), which is now the minimum supported version.
Skip SDAM error spec tests whose mock servers report wire versions below
the new minimum (9 / MongoDB 4.4), and update the test_wire_version
assertion to use MIN_SUPPORTED_WIRE_VERSION.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants