Skip to content

CSHARP-5871: Clarify phase description for "Network timeouts test" spec test#1919

Open
sanych-sun wants to merge 1 commit intomongodb:mainfrom
sanych-sun:csharp5871
Open

CSHARP-5871: Clarify phase description for "Network timeouts test" spec test#1919
sanych-sun wants to merge 1 commit intomongodb:mainfrom
sanych-sun:csharp5871

Conversation

@sanych-sun
Copy link
Member

No description provided.

@sanych-sun sanych-sun requested a review from a team as a code owner March 18, 2026 17:06
@sanych-sun sanych-sun added the chore Non–user-facing code changes (tests, build scripts, etc.). label Mar 18, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the SDAM “Network timeouts test” handshake spec to reflect that pre-handshake network timeouts are ignored (rather than marking the server Unknown), and adjusts the C# SDAM spec test runner to simulate the required error label.

Changes:

  • Add the SystemOverloadedError label to simulated timeout MongoConnectionExceptions in the SDAM spec test runner.
  • Update the handshake error handling spec test (YAML + JSON) to “Ignore network timeout … (beforeHandshakeCompletes)” and to expect an unchanged topology outcome.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/MongoDB.Driver.Tests/Specifications/server-discovery-and-monitoring/ServerDiscoveryAndMonitoringTestRunner.cs Labels simulated timeout connection exceptions with SystemOverloadedError so the driver’s pre-handshake SDAM handling ignores them.
specifications/server-discovery-and-monitoring/tests/errors/error_handling_handshake.yml Adjusts the “beforeHandshakeCompletes” timeout phase to be ignored and reuses the shared *outcome.
specifications/server-discovery-and-monitoring/tests/errors/error_handling_handshake.json Mirrors the YAML change by updating the phase description and expected outcome to remain RSPrimary / ReplicaSetWithPrimary.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Non–user-facing code changes (tests, build scripts, etc.).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants