CSHARP-5871: Clarify phase description for "Network timeouts test" spec test#1919
Open
sanych-sun wants to merge 1 commit intomongodb:mainfrom
Open
CSHARP-5871: Clarify phase description for "Network timeouts test" spec test#1919sanych-sun wants to merge 1 commit intomongodb:mainfrom
sanych-sun wants to merge 1 commit intomongodb:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the SDAM “Network timeouts test” handshake spec to reflect that pre-handshake network timeouts are ignored (rather than marking the server Unknown), and adjusts the C# SDAM spec test runner to simulate the required error label.
Changes:
- Add the
SystemOverloadedErrorlabel to simulated timeoutMongoConnectionExceptions in the SDAM spec test runner. - Update the handshake error handling spec test (YAML + JSON) to “Ignore network timeout … (beforeHandshakeCompletes)” and to expect an unchanged topology outcome.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/MongoDB.Driver.Tests/Specifications/server-discovery-and-monitoring/ServerDiscoveryAndMonitoringTestRunner.cs | Labels simulated timeout connection exceptions with SystemOverloadedError so the driver’s pre-handshake SDAM handling ignores them. |
| specifications/server-discovery-and-monitoring/tests/errors/error_handling_handshake.yml | Adjusts the “beforeHandshakeCompletes” timeout phase to be ignored and reuses the shared *outcome. |
| specifications/server-discovery-and-monitoring/tests/errors/error_handling_handshake.json | Mirrors the YAML change by updating the phase description and expected outcome to remain RSPrimary / ReplicaSetWithPrimary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.