DOCSP-55438 & DOCSP-55529: Unify .env vars and add new verification scripts for all three backends #85
Open
cbullinger wants to merge 7 commits intomainfrom
Open
DOCSP-55438 & DOCSP-55529: Unify .env vars and add new verification scripts for all three backends #85cbullinger wants to merge 7 commits intomainfrom
.env vars and add new verification scripts for all three backends #85cbullinger wants to merge 7 commits intomainfrom
Conversation
tmcneil-mdb
requested changes
Feb 23, 2026
Collaborator
tmcneil-mdb
left a comment
There was a problem hiding this comment.
Nice work!☀️
So this looks good to me but, we have a logical error in the order of the readme. At the top of the readmes, we are asking the user to verify the requirements, but this will always fail based on the script. The readme is walking the user through how to setup the environment, thus it would not pass until the user has gotten to the end.
You could move the verification to the end? Or perhaps break up the script?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.