feat: add structured content #780
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces structured content support for MCP tools, specifically implementing it for the insert-many tool. The change allows tools to return both human-readable text content and machine-parseable structured output.
Key changes:
- Added
outputShapeandToolResulttypes to define structured responses - Modified
insert-manytool to return structured content with success status, inserted count, and IDs - Updated tool registration to use new
registerToolmethod that accepts output schema
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tools/tool.ts | Defines ToolResult type and adds outputShape field to ToolBase class, updates tool registration to include output schema |
| src/tools/mongodb/create/insertMany.ts | Implements structured content for insert-many tool, defining output shape and returning structured response |
| tests/integration/tools/mongodb/create/insertMany.test.ts | Adds validation for structured content in all insert-many test cases |
| tests/integration/helpers.ts | Updates getResponseContent signature to handle structured content |
| package.json | Changes preview feature flag from vectorSearch to search |
Collaborator
Pull Request Test Coverage Report for Build 19923606969Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is mostly a POC for how adding structured content to tools could look like. I'm still torn between adding it as is and adding it also to the
formatUntrustedDatahelper - I've decided to keep them separate because I'm hoping we will eventually be able to remove the helper, though I'm very open to being convinced either way.