Conversation
Add subscription support for recurring payments: - SubscriptionSchema with status, period dates, and cancellation fields - SubscriptionWebhookPayloadSchema for subscription.* events - Subscription ORPC contracts (createRenewalCheckout, cancel, get)
Add customer endpoint support for subscription management: - CustomerSchema with subscriptions and hasActiveSubscription - CustomerSubscriptionSchema for subscription summaries - GetCustomerInputSchema with externalId/email/customerId lookup - customer.get ORPC contract
|
@codex Review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44e20820ff
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex Review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
…cription - Add z.string().datetime() validation to currentPeriodStart, currentPeriodEnd in SubscriptionSchema and CustomerSubscriptionSchema - Remove hasActiveSubscription from CustomerSchema as it can be derived from subscriptions array client-side
Allows the schema to handle edge cases while business logic enforces email requirement at subscription creation time.
Resolve conflicts: - package.json: use version 0.1.18 from main, keep prepare script - src/index.ts: add subscription to contracts, keep MCP schemas/contracts - src/contracts/customer.ts: keep both SDK and MCP customer endpoints - src/schemas/customer.ts: keep both CustomerSchema (SDK) and McpCustomerSchema (MCP)
2 participants
Summary
subscription.created,subscription.renewed,subscription.canceled,subscription.payment_failedget,createRenewalCheckout, andcancelendpointsRelated
Part of MDK-401 subscriptions MVP implementation.