added file path when getting compose logs#933
Open
nathn123 wants to merge 2 commits intomoghtech:mainfrom
Open
added file path when getting compose logs#933nathn123 wants to merge 2 commits intomoghtech:mainfrom
nathn123 wants to merge 2 commits intomoghtech:mainfrom
Conversation
Member
|
Currently these changes would be breaking, it must work with more than one / custom compose file path |
nathn123
force-pushed
the
add-compose-filepath
branch
from
576bbe9 to
5c5fd60
Compare
Member
|
I just don't like that this switches out working behavior for potentially breaking behavior for many users using docker. How about a new periphery config flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attempt to fix #932