Skip to content

fix: publish from package directory #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nsttt merged 1 commit into from
Mar 31, 2026
Merged

fix: publish from package directory #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/publish-on-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
fi

NEXT_VERSION="${BASE_VERSION}-next.${NEXT_NUMBER}"
npm pkg set version="$NEXT_VERSION" --workspace packages/astro
npm pkg set version="$NEXT_VERSION" --prefix packages/astro
echo "Set prerelease version: $NEXT_VERSION"

- name: Build package
Expand Down Expand Up @@ -177,7 +177,8 @@ jobs:

- name: Publish to npm
if: steps.publish_action.outputs.action == 'publish'
run: npm publish --provenance --tag "${{ steps.dist.outputs.dist_tag }}" --access public --workspace packages/astro
working-directory: packages/astro
run: npm publish --provenance --tag "${{ steps.dist.outputs.dist_tag }}" --access public
Comment on lines 178 to +181
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow no longer uses npm workspaces, but the repo still contains .github/workflows/release.yml which runs npm publish ... --workspace packages/astro (and will hit the same “No workspaces found” error described in the PR). If that workflow is still intended to be used, it should be updated similarly (publish from packages/astro or use --prefix), or removed to avoid a broken release path.

Copilot uses AI. Check for mistakes.

- name: Skip npm publish
if: steps.publish_action.outputs.action == 'skip'
Expand Down
5 changes: 3 additions & 2 deletions docs/RELEASING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ read_when:
- Preparing a release
- Wiring npm publish automation
- Updating release pipeline behavior
updated_at: 2026-03-30
updated_at: 2026-03-31
---

# Releasing
Expand All @@ -28,7 +28,8 @@ This repo uses Changesets for versioning and publishes `@module-federation/astro
- Release trigger: `latest` for stable releases, `next` for prereleases
- Manual trigger (`workflow_dispatch`): `latest` or `next`
- Pre-release versioning:
- On `prereleased` events, workflow patches `packages/astro/package.json` to `<base>-next.<N>` before publish.
- On `prereleased` events, workflow patches `packages/astro/package.json` to `<base>-next.<N>` before publish.
- npm publish runs from `packages/astro` directly; this repo uses `pnpm-workspace.yaml`, not root npm workspaces.
Comment on lines +31 to +32
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bullets under “Pre-release versioning:” are mis-indented (lines 31–32). As written, they won’t render as nested bullets under that heading, unlike the “Existing version handling” section below. Align these list items’ indentation with the other nested bullets (e.g., indent to the same level as lines 34–35).

Suggested change
- On `prereleased` events, workflow patches `packages/astro/package.json` to `<base>-next.<N>` before publish.
- npm publish runs from `packages/astro` directly; this repo uses `pnpm-workspace.yaml`, not root npm workspaces.
- On `prereleased` events, workflow patches `packages/astro/package.json` to `<base>-next.<N>` before publish.
- npm publish runs from `packages/astro` directly; this repo uses `pnpm-workspace.yaml`, not root npm workspaces.

Copilot uses AI. Check for mistakes.
- Existing version handling:
- If the exact version already exists on npm and already has the target dist-tag, publish is skipped.
- If the version exists but the target dist-tag points elsewhere, workflow fails.
Expand Down
Loading