refactor: TabbedModal to use NewModal and DI#5612
Merged
Conversation
Contributor
tdgao
commented
Mar 18, 2026
tdgao
commented
- Refactor TabbedModal to wrap NewModal, making it an actual modal with built-in tab navigation
- Add Storybook stories for TabbedModal
- Replace Tab generic props pattern with DI for InstanceSettingsModal
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
storybook | ed904e2 | Commit Preview URL Branch Preview URL |
Mar 18 2026, 06:07 PM |
Contributor
Frontend previewsLast deployed commit is 797e809cf177a5a7aa466960920e46375f7f36b7
|
IMB11
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.