[driver] Ili9341 support Resumable Functions#664
Closed
TomSaw wants to merge 1 commit intomodm-io:developfrom
Closed
[driver] Ili9341 support Resumable Functions#664TomSaw wants to merge 1 commit intomodm-io:developfrom
TomSaw wants to merge 1 commit intomodm-io:developfrom
Conversation
This was referenced Jul 29, 2021
Closed
8236785 to
cb1313d
Compare
Member
|
Can this be closed in favor of #665? |
Contributor
Author
|
Jupp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To sweep the yard for #665 , here's an as good as possible pealed out update on ILI9341.
Let's concentrate on the implementation of the Resumables for now.
Drawing functions and a lot more will be cured with the coming up graphics API rewrite.
Changes
clear()now also takes a color to clear with:clear(Rgb565 color)backgroundColor. RenamedforegroundColor->color. To fullfill this change, clear(Rgb565 color) needs to become sooper fast and resource unhungry. A concept witch gets final grip with the coming up graphics API rewrite ;)set(Toggle toggle, bool value)substitutes lots ofxyzOn(),xyzOff()methods.set(ReadWrite reg, uint8_t value)andget(ReadWrite reg, uint8_t value)substitute lots ofsetXyz(),getXyz()methods.modm::Ili9341Spi<Ili9341InterfaceSpi<Spi, Cs, Dc> Reset>reads and explains itself so much better than "simplified"modm::Ili9341Spi<SpiMaster, Cs, Dc, Reset>.<..., typename Backlight, ...>from DriverBacklight::setOutput(modm::Gpio::High)subsitutes the Feature. However, sometimes a developer wants more control f.e. backlight PWM-Dimmed or hardwired to VCC so is better to keep the LED out of Ili9341 and not bloat the drivers template arguments.ToDo