Skip to content

test(rollup-plugin-html): migrate from mocha/chai to node:test #3097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bennypowers wants to merge 2 commits into
base: master
Choose a base branch
from
Open

test(rollup-plugin-html): migrate from mocha/chai to node:test #3097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3f9b10
test(rollup-plugin-html): migrate from mocha/chai to node:test
bennypowers Jun 2, 2026
7f524d2
fix(rollup-plugin-html): use expectIncludes and restore test:watch sc…
bennypowers Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/rollup-plugin-html/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
"demo:mpa": "rm -rf demo/dist && rollup -c demo/mpa/rollup.config.js --watch & npm run serve-demo",
"demo:spa": "rm -rf demo/dist && rollup -c demo/spa/rollup.config.js --watch & npm run serve-demo",
"serve-demo": "node ../dev-server/dist/bin.js --watch --root-dir demo/dist --app-index index.html --compatibility none --open",
"test:node": "mocha test/**/*.test.ts --require ts-node/register --reporter dot",
"test:watch": "mocha test/**/*.test.ts --require ts-node/register --watch --watch-files src,test"

@bashmish bashmish Jun 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw you kept "watch" in other PRs, any specific reason to remove it here?

@bennypowers bennypowers Jun 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix

@bennypowers bennypowers Jun 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL 7f524d2

"test:node": "node --experimental-strip-types --test --test-force-exit 'test/**/*.test.ts'",
"test:watch": "node --experimental-strip-types --test --test-force-exit --watch 'test/**/*.test.ts'"
},
"files": [
"*.js",
Expand Down
Loading
Loading