refactor(rollup-plugin-import-meta-assets): migrate tests to node:test#3081
refactor(rollup-plugin-import-meta-assets): migrate tests to node:test#3081bennypowers wants to merge 3 commits into
Conversation
Replace mocha/chai/hanbi with node:test, node:assert/strict, and node:test mock API. Update test:node script to use `node --test`. - `expect(x).to.equal(y)` -> `assert.equal(x, y)` - `expect(x).to.deep.equal(y)` -> `assert.deepEqual(x, y)` - `expect(x).to.have.lengthOf(n)` -> `assert.equal(x.length, n)` - `expect(x).to.match(re)` -> `assert.match(x, re)` - `hanbi.stubMethod(console, 'warn')` -> `mock.method(console, 'warn')` - `hanbi.restore()` -> `mock.restoreAll()` - `consoleStub.callCount` -> `consoleStub.mock.callCount()` - `consoleStub.getCall(n).args` -> `consoleStub.mock.calls[n].arguments` - Removed `test:update-snapshots` script (no longer applicable) - Add `--test-force-exit` to prevent test hangs Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
| const path = require('path'); | ||
| const { rollup } = require('rollup'); | ||
| const { expect } = require('chai'); | ||
| const hanbi = require('hanbi'); |
There was a problem hiding this comment.
just double checking: you are going to remove hanbi and other dependencies which will not be used after all refactorings, in a separate PR once all are complete?
There was a problem hiding this comment.
yes, after all refactor PRs are complete
| expect(chunks['app.js']).to.equal(js` | ||
| assert.equal( | ||
| chunks['app.js'], | ||
| js` |
There was a problem hiding this comment.
the format is a bit off in here and I think in all other similar cases
looks like prettier doesn't like this as a one-liner
assert.equal(chunks['app.js'], js`
but then it should change the indentation of code lines which doesn't happen either
can you please check this? if you do this with copilot, maybe you can ask it to fix such indentation issues
looks like in some other PRs the indentation was refactored correctly in similar cases, e.g. in #3097
There was a problem hiding this comment.
that's just how prettier wanted it. i'm just as happy to launch prettier into the sun and never think about it again.
There was a problem hiding this comment.
prettier is not perfect when it comes to code blocks indentation, but the indentation needs to be fixed, lack of prettier won't fix it either
There was a problem hiding this comment.
reverted the indentation changes for the content lines
if prettier doesn't like that, i think we should remove it
…ion in assert.equal blocks Re-indent template literal content inside assert.equal() calls to match the new nesting level after the chai-to-assert migration. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…indentation in assert.equal blocks" This reverts commit fdeb39e.
2 participants
Summary
@web/rollup-plugin-import-meta-assetstests from mocha/chai/hanbi tonode:test+node:assert/strict+node:testmock APItest:nodescript from mocha tonode --test --test-force-exitmock.method/mock.restoreAlltest:update-snapshotsscript (no longer applicable with node:test)Test plan