Merged
Conversation
The agent now auto-generates a unique localRepository path
(~/.moderne-maven/maven{index}) when not explicitly configured.
This setting is only relevant when astSource is true.
mike-solomon
approved these changes
Feb 4, 2026
Contributor
|
@kmccarp Any updates on the status of this? Are we good to merge in or does it need to wait further? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localRepositoryfrom required to optional in all Maven configuration documentationastSourceistrueandlocalRepositoryis not specified, the agent now auto-generates a unique path (~/.moderne-maven/maven{index}) based on the configuration indexlocalRepositoryfrom recipe-only configuration docs and examples (whereastSource=false) since it is not relevant in that contextRelated PRs
Test plan
localRepositoryas optional with correct defaultlocalRepositoryunless explicitly neededlocalRepositoryfield