Support Redis clients created with decode_responses=True#22
Merged
Conversation
The CLAIM Lua reply is the binary BinaryMessageFormatV1 envelope, so a client with decode_responses=True would raise UnicodeDecodeError on every fetch — and because NACK_ON_ERROR leaves the timer in the timeline, every poison timer looped forever. Route eval_cached through execute_command(..., NEVER_DECODE=[]) so the script reply stays raw regardless of the client's decode mode. zrangebyscore results were already tolerant of either return type via isinstance checks; just widen the annotations to list[bytes] | list[str]. Introduce a RedisClient type alias to thread the broader client type through the public surface. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLAIM Lua reply is the binary BinaryMessageFormatV1 envelope, so a client with decode_responses=True would raise UnicodeDecodeError on every fetch — and because NACK_ON_ERROR leaves the timer in the timeline, every poison timer looped forever.
Route eval_cached through execute_command(..., NEVER_DECODE=[]) so the script reply stays raw regardless of the client's decode mode. zrangebyscore results were already tolerant of either return type via isinstance checks; just widen the annotations to list[bytes] | list[str]. Introduce a RedisClient type alias to thread the broader client type through the public surface.