Use per-topic key shape in README "How it works"#16
Merged
Conversation
The README listed the Redis structures as bare `timers_timeline` /
`timers_payloads`, but actual keys are `{prefix_key}:{full_topic}` (see
`subscriber/config.py:24-30`). Anyone debugging via `redis-cli` would
not find the bare keys. Update the README to show the
`{key}:{topic}` shape, give a concrete example, and mention that
`TimersRouter(prefix=...)` extends the suffix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README listed the Redis structures as bare
timers_timeline/timers_payloads, but actual keys are{prefix_key}:{full_topic}(seesubscriber/config.py:24-30). Anyone debugging viaredis-cliwould not find the bare keys. Update the README to show the{key}:{topic}shape, give a concrete example, and mention thatTimersRouter(prefix=...)extends the suffix.