Use UNLINK in cancel_all, document leased-timer semantics, plumb client through claim#13
Merged
Use UNLINK in cancel_all, document leased-timer semantics, plumb client through claim#13
Conversation
Member
lesnik512
commented
May 3, 2026
- O4: cancel_all now uses UNLINK instead of DEL so freeing large topic keys runs in Redis's background thread (Redis 4.0+).
- S1: get_pending_timers docstring spells out that leased (in-flight) timers appear in the default call but are excluded once before is set to "now".
- S2: cancel_all docstring notes that handlers already executing for a leased timer continue to run to completion; their final commit is a no-op because the keys are gone.
- B6: _claim_and_consume now receives client via tg.start_soon instead of resolving self._client, so the whole subscriber poll-and-claim path uses one consistent client reference.
…nt through claim - O4: cancel_all now uses UNLINK instead of DEL so freeing large topic keys runs in Redis's background thread (Redis 4.0+). - S1: get_pending_timers docstring spells out that leased (in-flight) timers appear in the default call but are excluded once before is set to "now". - S2: cancel_all docstring notes that handlers already executing for a leased timer continue to run to completion; their final commit is a no-op because the keys are gone. - B6: _claim_and_consume now receives client via tg.start_soon instead of resolving self._client, so the whole subscriber poll-and-claim path uses one consistent client reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.