scope cancellation watermarks per consumer#24
Merged
Conversation
The watermark dict was keyed by TopicPartition only. When a single KafkaConcurrentHandler is shared across subscribers in different consumer groups subscribing to the same topic, a cancelled task on one group blocks commits on the other for the same partition. Re-key _cancellation_watermarks as dict[(id(consumer), TopicPartition)] and track a _partition_owner: dict[TopicPartition, int] inside the streaming loop so clear_cancellation_watermarks(partitions) can resolve which consumer's entry to drop on rebalance — listener API stays the same. Adds a focused regression test that fails under the old keying. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The watermark dict was keyed by TopicPartition only. When a single KafkaConcurrentHandler is shared across subscribers in different consumer groups subscribing to the same topic, a cancelled task on one group blocks commits on the other for the same partition.
Re-key _cancellation_watermarks as dict[(id(consumer), TopicPartition)] and track a _partition_owner: dict[TopicPartition, int] inside the streaming loop so clear_cancellation_watermarks(partitions) can resolve which consumer's entry to drop on rebalance — listener API stays the same. Adds a focused regression test that fails under the old keying.