fix doc drift and misleading add_done_callback comments#23
Merged
Conversation
README/CLAUDE.md: SIGQUIT was never wired up (only SIGTERM/SIGINT); shutdown timeout default is 20 s not 10 s; the in-flight task tracker is now a counter + asyncio.Event (set was dropped in 1aba826); the shutdown wait uses Event.wait() not asyncio.gather; KafkaBatchCommitter description rewritten for the streaming loop. Also corrected the DI middleware ordering claim — first registered is outermost in FastStream broker_middlewares (verified against faststream _internal/endpoint/subscriber). processing.py / batch_committer.py: comments claimed add_done_callback fires synchronously when the future is already done; per Python docs it always schedules via loop.call_soon. Reworded to describe the actual mechanism. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README/CLAUDE.md: SIGQUIT was never wired up (only SIGTERM/SIGINT); shutdown timeout default is 20 s not 10 s; the in-flight task tracker is now a counter + asyncio.Event (set was dropped in 1aba826); the shutdown wait uses Event.wait() not asyncio.gather; KafkaBatchCommitter description rewritten for the streaming loop. Also corrected the DI middleware ordering claim — first registered is outermost in FastStream broker_middlewares (verified against faststream _internal/endpoint/subscriber).
processing.py / batch_committer.py: comments claimed add_done_callback fires synchronously when the future is already done; per Python docs it always schedules via loop.call_soon. Reworded to describe the actual mechanism.