drop _current_tasks set; back wait_for_subtasks with count + Event#22
Merged
drop _current_tasks set; back wait_for_subtasks with count + Event#22
Conversation
The set existed only so wait_for_subtasks could iterate it during graceful shutdown — and it had to re-collect after every gather() to catch tasks added during the wait. Replace it with an int counter and an asyncio.Event that's set when the counter hits zero. wait_for_subtasks becomes a single asyncio.wait_for(event.wait(), timeout=...) call. Tasks added during the wait increment the counter and clear the event, so the wait extends naturally — no re-collect loop needed. Test rewrite: 9 tests in test_concurrent_processing.py manipulated _current_tasks directly. They now use a small _track_external helper that mirrors handle_task's bookkeeping (increment count + clear event + register the done-callback), so externally-injected tasks still register with wait_for_subtasks. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The set existed only so wait_for_subtasks could iterate it during graceful shutdown — and it had to re-collect after every gather() to catch tasks added during the wait. Replace it with an int counter and an asyncio.Event that's set when the counter hits zero. wait_for_subtasks becomes a single asyncio.wait_for(event.wait(), timeout=...) call. Tasks added during the wait increment the counter and clear the event, so the wait extends naturally — no re-collect loop needed.
Test rewrite: 9 tests in test_concurrent_processing.py manipulated _current_tasks directly. They now use a small _track_external helper that mirrors handle_task's bookkeeping (increment count + clear event + register the done-callback), so externally-injected tasks still register with wait_for_subtasks.