-
Notifications
You must be signed in to change notification settings - Fork 21
Workflow for periodically building top models from huggingFace #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Workflow for periodically building top models from huggingFace #371
Conversation
Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
Summary of ChangesHello @avinashsingh77, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes an automated pipeline for curating and building popular machine learning models from HuggingFace Hub. By introducing a new GitHub workflow and an accompanying Python script, it ensures that a selection of modctl-compatible models are regularly identified, processed, and made available in ghcr.io, enhancing the accessibility and freshness of pre-built models. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR introduces a useful workflow and script for selecting top models from HuggingFace. The Python script is well-structured and includes good features like command-line arguments and fallback for older library versions. My review includes a few suggestions to improve robustness, performance, and correctness. Specifically, I've pointed out places where exception handling can be improved to aid debugging, suggested some performance optimizations for list lookups, and fixed a typo in the documentation. Overall, this is a great addition.
Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
This PR adds the following:
Closes #309