Skip to content

Clarify restrictions on fill patterns. #3789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HansOlsson wants to merge 8 commits into
base: master
Choose a base branch
from
+7 −1
Open

Clarify restrictions on fill patterns. #3789

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c82f3e0
Clarify restrictions on fill patterns.
HansOlsson Dec 4, 2025
54fc829
Update chapters/annotations.tex
HansOlsson Dec 15, 2025
9b031b2
Further clarified.
HansOlsson Dec 15, 2025
becd5f2
WS
HansOlsson Dec 15, 2025
97147a4
Update chapters/annotations.tex
HansOlsson Dec 16, 2025
0ba10a8
Reformulated
HansOlsson Dec 16, 2025
864220b
MergedUpdate
HansOlsson Dec 16, 2025
ad8bbdb
Apply suggestions from code review
HansOlsson Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion chapters/annotations.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,13 @@ \subsubsection{Graphical Properties}\label{graphical-properties}
The \lstinline!FillPattern! attributes \lstinline!Horizontal!, \lstinline!Vertical!, \lstinline!Cross!, \lstinline!Forward!, \lstinline!Backward! and \lstinline!CrossDiag! specify fill patterns drawn with the line color over the fill color.

The attributes \lstinline!HorizontalCylinder!, \lstinline!VerticalCylinder! and \lstinline!Sphere! specify gradients that represent a horizontal cylinder, a vertical cylinder and a sphere, respectively.
The gradient goes from line color to fill color.
Gradients are defined for the geometry of a \lstinline!GraphicItem! before its \lstinline!rotation! is applied.
The coloring is defined for an enclosing shape, and then clipped to the actual shape of the \lstinline!GraphicItem!.
For \lstinline!HorizontalCylinder! and \lstinline!VerticalCylinder!, the minimal enclosing axis-parallel rectangle is used, while \lstinline!Sphere! uses the smallest enclosing ellipse.
Copy link
Collaborator

@henrikt-ma henrikt-ma Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be clarified that we don't mean the less computationally tractable smallest-perimeter ellipse:

Suggested change
For \lstinline!HorizontalCylinder! and \lstinline!VerticalCylinder!, the minimal enclosing axis-parallel rectangle is used, while \lstinline!Sphere! uses the smallest enclosing ellipse.
For \lstinline!HorizontalCylinder! and \lstinline!VerticalCylinder!, the minimal enclosing axis-parallel rectangle is used, while \lstinline!Sphere! uses the smallest area enclosing ellipse.

The enclosing shapes are defined considering full rectangles (ignoring rounded corners) and full ellipses (ignoring arcs).
For \lstinline!HorizontalCylinder!, the gradient attains the fill color along the horizontal line dividing the enclosing rectangle at the center, and the line color at the two horizontal sides of the rectangle.
The \lstinline!VerticalCylinder! is defined analogously to \lstinline!HorizontalCylinder!, but using vertical lines.
For \lstinline!Sphere!, the gradient attains the fill color at the center of the enclosing ellipse, and the line color along the entire border of the ellipse.

The border pattern attributes \lstinline!Raised!, \lstinline!Sunken! and \lstinline!Engraved! represent frames which are rendered in a tool-dependent way --- inside the extent of the filled shape.

Expand Down