Open
Conversation
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
Contributor
Author
|
@claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace custom
RequestInfowith standard WebRequestobjectMotivation and Context
Closes #1351. The custom
RequestInfointerface only exposedheaders, discarding the rest of the incoming HTTP request (URL, query params, method). Instead of incrementally adding fields likequeryString, this replaces the entire custom type with the standard WebRequestobject that the transport already receives. Users now have access to headers, URL, query parameters, HTTP method, and anything else the WebRequestAPI provides.How Has This Been Tested?
urlandmethodon the exposedRequestobjectnew URL(req.url).searchParamswhen the client sends a request with query paramspnpm typecheck:all,pnpm lint:all, andpnpm test:allpassBreaking Changes
ctx.http?.reqis now a standard WebRequestinstead of the customRequestInfotype. The most common access pattern (ctx.http?.req?.headers.get(...)) is unchanged sinceRequesthas the sameheaders: Headersproperty. TheRequestInfotype has been removed — it was not part of the public API exports.Types of changes
Checklist
Additional context
globalThis.Requestin type annotations to disambiguate from the MCP protocol's ownRequesttype intypes.tsandprotocol.tsmigration.mdandmigration-SKILL.md) updated with new examples showing query param access