client: suppress duplicate abort errors during StreamableHTTP close#1817
Open
windro-xdd wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Conversation
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamableHTTPClientTransportto suppress abort-drivenonerroremissions while shutdown is in progress_emitErrorhelper to avoid duplicate callback pathsclient.close()abort behaviorWhy
Issue #868 reports duplicate
onerrorcallbacks when closing a Streamable HTTP client. During shutdown, in-flight requests can reject withAbortError, and those errors should not be surfaced as user-facing failures after an intentional close.Validation
pnpm --filter @modelcontextprotocol/client test -- test/client/streamableHttp.test.tspnpm --filter @modelcontextprotocol/client typecheckpnpm --filter @modelcontextprotocol/client lintCloses #868