fix: allow $schema and additionalProperties in elicitation requestedSchema#1812
Open
kai-agent-free wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: allow $schema and additionalProperties in elicitation requestedSchema#1812kai-agent-free wants to merge 1 commit intomodelcontextprotocol:mainfrom
kai-agent-free wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
…chema Zod's .toJSONSchema() adds $schema and additionalProperties fields which are not harmful but cause TypeScript errors when passed directly to elicitInput(). This adds both as optional fields to the schema definition and TypeScript interface. Fixes modelcontextprotocol#1362
🦋 Changeset detectedLatest commit: 3fd356f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Zod's
.toJSONSchema()output includes$schemaandadditionalPropertiesfields that are not harmful but cause TypeScript errors when passed toelicitInput()'srequestedSchemaparameter.The TypeScript interface in
spec.types.tsalready allows$schemabut the Zod validation schema inschemas.tsstrips/rejects it. Neither allowsadditionalProperties.Fix
$schema: z.string().optional()to the Zod schema inschemas.tsadditionalProperties: z.boolean().optional()to both the Zod schema and TypeScript interfaceThis makes
z.object({...}).toJSONSchema()output directly usable asrequestedSchemawithout type casting.Fixes #1362